Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definitions for createImageBitmap #7483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ollelauribostrom
Copy link

@ollelauribostrom ollelauribostrom commented Feb 17, 2019

#7362. Not 100% sure which parts should go in the bom.js vs dom.js. Would love some feedback on this 🙂

Relevant documentation

@nmote nmote requested a review from dsainati1 February 19, 2019 19:15
@nmote nmote added the Library definitions Issues or pull requests about core library definitions label Feb 19, 2019
@nmote nmote removed the request for review from dsainati1 February 19, 2019 19:15
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsainati1 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dsainati1
Copy link
Contributor

This has type and parse errors in dom.js and bom.js. Can you fix these?

@goodmind goodmind added the Stalled Issues and PRs that are stalled. label Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Library definitions Issues or pull requests about core library definitions Stalled Issues and PRs that are stalled.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants