fix: Add aria-expanded for mobile navigation dropdown #9463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
The mobile navigation dropdown does not convey the expanded state to assistive technologies such as a screen reader, it's also not focusable
https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-a-element
It would be preferable to use an HTML button (a button should work with
SPACE
onKeyUp
andENTER
onKeyDown
) I think it could be done in another PR (styling changes would be needed)Test Plan
Can be tested on Docusaurus website homepage with a zoom to trigger the mobile version:
enter
orspace
On the chrome accessibility tree view, we can see that:
expanded: false
expanded: true
Test links
Deploy preview: https://deploy-preview-9463--docusaurus-2.netlify.app/
Related issues/PRs
Quite similar to: