Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-classic): add social icons for mastodon and bluesky #10764

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cemerick
Copy link

@cemerick cemerick commented Dec 13, 2024

Pre-flight checklist

Motivation

Allow blog authors to display mastodon & bluesky social icons without swizzling. Pre-PR discussion @ #10762

Note that this does not do anything fancy re: generating the actual social URL from anything shorter than an actual URL, since bluesky and mastodon profile links can have ~arbitrary domains, etc.

Test Plan

These are just icons, so no tests added here. Tweaks made to a dogfooding page and the authors file there to make sure the new icons show up. I also did do a sanity check with my own site. 👍

Test links

Deploy preview: https://deploy-preview-10764--docusaurus-2.netlify.app/tests/blog

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 13, 2024
Copy link

netlify bot commented Dec 13, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit df48c10
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/675de4cc94e02c0008840793
😎 Deploy Preview https://deploy-preview-10764--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 13, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 40 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 50 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@cemerick
Copy link
Author

I see some "lint" failures, but it seems it's just complaining about unknown terms ("bluesky", etc). I was about to update project-words.txt (where it seems such things are enumerated), but it's apparently a CI-generated file?

Let me know if there's anything I should do here to address this.

@Josh-Cena
Copy link
Collaborator

You can run the command yarn lint:spelling:fix locally to update this file!

@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Dec 13, 2024
@cemerick
Copy link
Author

You can run the command yarn lint:spelling:fix locally to update this file!

I've been incrementally resolving the problems reported by the linter(s), most recently prettier formatting. However, it looks like I've updated the PR more times than github likes before it's forcing a maintainer's approval to re-run those workflows again. 👉👈

@GingerGeek
Copy link
Contributor

Hey @cemerick I see we both wanted the same thing 😅

I have a similar PR in #10768 which also includes link handling for new social sites as well the icon inclusion

@cemerick
Copy link
Author

@GingerGeek You've got more (very reasonable IMO) social sites added, so I'm happy to have yours taken instead 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants