-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme-classic): add social icons for mastodon and bluesky #10764
base: main
Are you sure you want to change the base?
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
I see some "lint" failures, but it seems it's just complaining about unknown terms ("bluesky", etc). I was about to update project-words.txt (where it seems such things are enumerated), but it's apparently a CI-generated file? Let me know if there's anything I should do here to address this. |
You can run the command |
7c893ba
to
74bb687
Compare
74bb687
to
df48c10
Compare
I've been incrementally resolving the problems reported by the linter(s), most recently |
@GingerGeek You've got more (very reasonable IMO) social sites added, so I'm happy to have yours taken instead 👍 |
Pre-flight checklist
Motivation
Allow blog authors to display mastodon & bluesky social icons without swizzling. Pre-PR discussion @ #10762
Note that this does not do anything fancy re: generating the actual social URL from anything shorter than an actual URL, since bluesky and mastodon profile links can have ~arbitrary domains, etc.
Test Plan
These are just icons, so no tests added here. Tweaks made to a dogfooding page and the authors file there to make sure the new icons show up. I also did do a sanity check with my own site. 👍
Test links
Deploy preview: https://deploy-preview-10764--docusaurus-2.netlify.app/tests/blog