Support Clang on Windows in prelude #804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
IanChilds
requested changes
Dec 17, 2024
| @@ -1379,8 +1379,7 @@ def _strip_objects(ctx: AnalysisContext, objects: list[Artifact]) -> list[Artifa | |||
| cxx_toolchain_info = get_cxx_toolchain_info(ctx) | |||
|
|
|||
| # Stripping is not supported on Windows | |||
| linker_type = cxx_toolchain_info.linker_info.type | |||
| if linker_type == LinkerType("windows"): | |||
| if host_info().os.is_windows: | |||
There was a problem hiding this comment.
In general, using host_info() is an anti-pattern, because it breaks cross-platform builds. I don't think we want to introduce any usages of host_info in these files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with
system_cxx_toolchainon Windows, it hardcodes usage of MSVC. The changes in this PR enabled me to set the relevant options in system_cxx_toolchain / cxx_toolchain to successfully build my project with Clang on Windows. The changes mostly involved updating code that made the assumption Windows being the host system implied msvc was the only option, leading to faulty flags being set.I attempted to run tests locally with
cargo test, but experienced various errors including my computer crashing, errors about pagefile too small, and running out of disk space, so eventually gave up on that.