Add support to upload action results to an RE client.

[hugwijst]

No description provided.

[thoughtpolice]

Awesome, this looks like an even more thorough version of #764 which I filed a few days ago, and is a revive of an older PR, which I'm not sure you saw. Did you test it with symlinks? I'm happy to abandon my patch in favor of this once since it looks better at a glance anyway.

EDIT: I'm alternatively happy to port your changes into my patch if you'd like, but frankly I'm just hopeful some version of this patch goes in one way more another, soonish.

[thoughtpolice]

See also #765 which is needed to fix stdout uploads in the local caching case.

[hugwijst]

Awesome, this looks like an even more thorough version of #764 which I filed a few days ago, and is a revive of an older PR, which I'm not sure you saw. Did you test it with symlinks? I'm happy to abandon my patch in favor of this once since it looks better at a glance anyway.

I did not see your version, nor did I try symlinks explicitly. I just implemented the converse of convert_action_result which was easier than I anticipated. I have some internal use case for which this seems to cache correctly, but don't have explicit tests.

EDIT: I'm alternatively happy to port your changes into my patch if you'd like, but frankly I'm just hopeful some version of this patch goes in one way more another, soonish.

I'm happy to go either way too, your PR looks like it has more comments 😅 I too would like to see this feature mainlined soonish.

[hugwijst]

See also #765 which is needed to fix stdout uploads in the local caching case.

Oh, interesting. I hadn't run into that yet, but good to know where to look when I do.

[hugwijst]

@thoughtpolice, I just found another bug where buck2 ignores the preferred hashing algorithm when checking if it can upload to action cache, instead always using SHA1. See #784 for a fix.

[dmezh]

@JakobDegen Gentle bump on this one and #784

[facebook-github-bot]

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.