buck2_validation: tweak and slightly improve error message #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
thoughtpolice
force-pushed
the
aseipp/push-uxtzlovqlops
branch
4 times, most recently
from
b7f8aaf to
d93ae63
Compare
thoughtpolice
force-pushed
the
aseipp/push-uxtzlovqlops
branch
2 times, most recently
from
24e0bcf to
8b24471
Compare
thoughtpolice
force-pushed
the
aseipp/push-uxtzlovqlops
branch
from
8b24471 to
010f9b3
Compare
thoughtpolice
force-pushed
the
aseipp/push-uxtzlovqlops
branch
2 times, most recently
from
e3b9f8d to
7aacdf1
Compare
thoughtpolice
force-pushed
the
aseipp/push-uxtzlovqlops
branch
from
7aacdf1 to
47c4740
Compare
thoughtpolice
force-pushed
the
aseipp/push-uxtzlovqlops
branch
from
47c4740 to
ee9f2b1
Compare
thoughtpolice
force-pushed
the
aseipp/push-uxtzlovqlops
branch
2 times, most recently
from
43e16f1 to
ab62fdc
Compare
Previously, when using `ValidationInfo()` with a failure, it ends up turning out
an awkward message that turns
{ "status": "failure", "message": "you failed the test!" }
into
"you failed the test!".
After this patch, it comes out as:
you failed the test!
Which seems much more reasonable and easy to parse. It also gives the validation
message more control over the punctuation.
Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-uxtzlovqlops
branch
from
ab62fdc to
4705939
Compare
blackm00n
requested changes
Dec 9, 2024
There was a problem hiding this comment.
First of all, thanks for the PR! @thoughtpolice do you mind also fixing the tests since we check the how validation messages are rendered in our e2e suite?
Comment on lines
43
to
48
| pub(crate) fn rendered_message(&self) -> Cow<str> { | ||
| self.short_message.as_deref().map_or_else( | ||
| || Cow::Borrowed("Diagnostic message is missing from validation result"), | ||
| |x| Cow::Owned(format!("\"{}\"", x)), | ||
| |x| Cow::Owned(format!("{}", x)), | ||
| ) | ||
| } |
There was a problem hiding this comment.
With this change it could be just simplified to return &str:
pub(crate) fn rendered_message(&self) -> &str {
self.short_message.as_deref().unwrap_or("Diagnostic message is missing from validation result")
}
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using
ValidationInfo()with a failure, it ends up turning out an awkward message that turnsinto
After this patch, it comes out as:
Which seems much more reasonable and easy to parse. It also gives the validation message more control over the punctuation.