rust-project: name the binary buck2-rust-project
#752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
The name `rust-project` is glamorous but far too generic to be meaningful when talking about it, and it's not immediately clear what it's even referring to (imagine searching for it on Google). I think `buck2-rust-project` is *much* better and also gives a template for follow up tools like e.g. `buck2-cxx- project` Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-qkwrznssnklk
branch
from
409f272 to
d6d8fa2
Compare
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
rust-projectis glamorous but far too generic to be meaningful when talking about it, and it's not immediately clear what it's even referring to (imagine searching for it on Google). I thinkbuck2-rust-projectis much better and also gives a template for follow up tools like e.g.buck2-cxx- project