Add no_prelude remote execution to github actions #738
+89
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Enabling testing of remote execution on github actions for `no_prelude` * Create github action that generates .buckconfig.local using `NATIVELINK_HEADER_RW_KEY` from gha secrets. * Set `container-image` used for remote execution specific to setup of buck2. * Update .gitignore to include .buckconfig.local. * Include a `platforms` configuration for the `no_prelude` example. * Update `go_toolchain.bzl` to be remote enabled friendly, no need to download a toolchain when remote worker has one. Open question: * Was the downloading of go toolchain to be remote execution compatible prior to this change?
adam-singer
force-pushed
the
adams/re-nativelink-no-prelude-gh-action
branch
from
3dd7d4c to
5f3b9be
Compare
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling testing of remote execution on github actions for
no_preludeNATIVELINK_HEADER_RW_KEYfrom gha secrets.container-imageused for remote execution specific to setup of buck2.platformsconfiguration for theno_preludeexample.go_toolchain.bzlto be remote enabled friendly, no need to download a toolchain when remote worker has one.Open question:
cc: @JakobDegen