config diff old/new fix

Summary: I wrongly assumed we store new config in a dice. But it is not true. Just swapping two args to make diff calculation correct

Reviewed By: blackm00n

Differential Revision: D58668343

fbshipit-source-id: ab6f05aa8dc088b861057011ee7f23a4fd3195f3

app/buck2_server/src/ctx.rs

@@ -521,7 +521,7 @@ impl CellConfigLoader {
                 let (new_configs, config_metrics) = if dice_ctx.is_injected_legacy_configs_key_set().await? {
                     let injected_legacy_configs = dice_ctx.get_injected_legacy_configs().await?;
                     let root_cell = cells_and_configs.cell_resolver.root_cell();
-                    let diff_data = ConfigDiffMetrics::new(root_cell, &injected_legacy_configs, &cells_and_configs.configs_by_name);
+                    let diff_data = ConfigDiffMetrics::new(root_cell, &cells_and_configs.configs_by_name, &injected_legacy_configs);
                     (diff_data.has_changed(), Some(diff_data))
                 } else {
                     // first invocation of a daemon