Revert "try verifying indexing directly in test_api"

This reverts commit f27623d.
facebook · Oct 2, 2024 · 89f5c7d · 89f5c7d
1 parent f27623d
commit 89f5c7d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/hasher-matcher-actioner/src/OpenMediaMatch/blueprints/matching.py b/hasher-matcher-actioner/src/OpenMediaMatch/blueprints/matching.py
@@ -328,9 +328,16 @@ def index_cache_is_stale() -> bool:
 def _get_index(signal_type: t.Type[SignalType]) -> SignalTypeIndex[int] | None:
     entry = _get_index_cache().get(signal_type.get_name())
 
+    if entry is not None and is_in_pytest():
+        entry.reload_if_needed(get_storage())
+
     if entry is None:
         current_app.logger.debug("[lookup_signal] no cache, loading index")
         return get_storage().get_signal_type_index(signal_type)
     if entry.is_ready:
         return entry.index
     return None
+
+
+def is_in_pytest():
+    return "pytest" in sys.modules
diff --git a/hasher-matcher-actioner/src/OpenMediaMatch/tests/test_api.py b/hasher-matcher-actioner/src/OpenMediaMatch/tests/test_api.py
@@ -2,7 +2,6 @@
 
 import typing as t
 
-from OpenMediaMatch.blueprints.matching import IndexCache, _get_index_cache
 from flask.testing import FlaskClient
 from flask import Flask
 
@@ -193,8 +192,6 @@ def test_banks_add_hash_index(app: Flask, client: FlaskClient):
 
     # Build index
     build_all_indices(storage, storage, storage)
-    cache = _get_index_cache().get("pdq")
-    cache.reload_if_needed(get_storage())
 
     # Test against first image
     post_response = client.get(