Reduce complexity in wait_for_trials_and_report_results
#3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67178422 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3175 +/- ##
==========================================
- Coverage 95.82% 95.82% -0.01%
==========================================
Files 503 503
Lines 50850 50840 -10
==========================================
- Hits 48727 48716 -11
- Misses 2123 2124 +1 ☔ View full report in Codecov by Sentry. |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Dec 13, 2024
) Summary: This diff contains the following changes: 1. Deprecates ESSs `seconds_between_polls`, as we can leverage SchedulerOption's `init_seconds_between_polls` instead 2. Set SchedulerOption's `seconds_between_polls_backoff_factor` to 1 if an ESS is provided 3. Use a try-catch in `wait_for_completed_trials_and_report_results` when doing `idle_callback`, so it doesn't fail the Scheduler Differential Revision: D67178422
paschai
force-pushed
the
export-D67178422
branch
from
71a75c7 to
078c923
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67178422 |
) Summary: This diff contains the following changes: 1. Deprecates ESSs `seconds_between_polls`, as we can leverage SchedulerOption's `init_seconds_between_polls` instead 2. Set SchedulerOption's `seconds_between_polls_backoff_factor` to 1 if an ESS is provided 3. Use a try-catch in `wait_for_completed_trials_and_report_results` when doing `idle_callback`, so it doesn't fail the Scheduler Reviewed By: mgarrard Differential Revision: D67178422
paschai
force-pushed
the
export-D67178422
branch
from
078c923 to
5e2d4dd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67178422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff contains the following changes:
seconds_between_polls, as we can leverage SchedulerOption'sinit_seconds_between_pollsinsteadseconds_between_polls_backoff_factorto 1 if an ESS is providedwait_for_completed_trials_and_report_resultswhen doingidle_callback, so it doesn't fail the SchedulerDifferential Revision: D67178422