Vizier sklearn transforms and PowerTransformY refactor #3153
+1,455
−223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Vizier Transforms as sklearn transformers and then creates a base class for applying such transformers. This refactor allows us to reuse most of the code in the PowerTransformY class and is hopefully fairly extensible. In future in may be possible to upstream the implementations of the vizier sklearn transformers somewhere else.
Because the power transformer already relied on sklearn this felt like a nice pattern.
Still need to write tests for the Ax transformer classes but have written tests and double checked the behaviour of the transforms.