Simplify function for generating runtimes for benchmarking #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Context: `async_runtime_func_from_pi` was a way of deterministically getting a quasi-random number from a trial index by using the trial index to look up a digit of pi. This was unnecessarily weird and wouldn't make sense once we start determining runtimes based on parameterizations rather than trial index in D66313060. This PR: * Add a function that generates an int between 0 and 9 by hashing the parameters of the trial's first arm, using `Arm.md5hash`. * Pulls out a function for doing this based on parameters, looking ahead to D66313060. * Change `Arm.md5hash` to not mutate the parameters; update some function signatures in `arm.py` to indicate that they do not mutate parameters. Reviewed By: Balandat Differential Revision: D66460608
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66460608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
async_runtime_func_from_piwas a way of deterministically getting a quasi-random number from a trial index by using the trial index to look up a digit of pi. This was unnecessarily weird and wouldn't make sense once we start determining runtimes based on parameterizations rather than trial index in D66313060.This PR:
Arm.md5hash.Arm.md5hashto not mutate the parameters; update some function signatures inarm.pyto indicate that they do not mutate parameters.Reviewed By: Balandat
Differential Revision: D66460608