Latest observations from MapData #3112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
force-pushed
the
export-D66434621
branch
from
f9afc32 to
9027a1d
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 26, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
9027a1d to
fd76ff0
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 27, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
force-pushed
the
export-D66434621
branch
from
fd76ff0 to
e25946f
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 28, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
force-pushed
the
export-D66434621
branch
from
e25946f to
7f8f3b3
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 28, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3112 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 493 493
Lines 49949 49974 +25
=======================================
+ Hits 47662 47689 +27
+ Misses 2287 2285 -2 ☔ View full report in Codecov by Sentry. |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
Summary: * Provide a new method `latest` for `MapData` to retrieve the n most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed n values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. * Modify the "upcast" df property to leverage `latest`, which is a special case with n=1. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
7f8f3b3 to
0105f0e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
0105f0e to
1efcb42
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
facebook#3112) Summary: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 5, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 9, 2024
facebook#3112) Summary: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
1efcb42 to
652714f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 9, 2024
Summary: Pull Request resolved: facebook#3112 Differential Revision: D66434621
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 9, 2024
facebook#3112) Summary: * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
652714f to
4523b8a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
added 4 commits
December 11, 2024 20:02
…re (facebook#3023) Summary: Pull Request resolved: facebook#3023 This implements a new transform, `MetadataToRange`, which extracts specified fields from each `ObservationFeature` instance's metadata and incorporates them as parameters. Furthermore, it updates the search space to include the specified field as a `RangeParameter` with bounds determined by observations provided during initialization. This process involves analyzing the metadata of each observation feature and identifying relevant fields that need to be included in the search space. The bounds for these fields are then determined based on the observations provided during initialization. Differential Revision: D65430943
…aults for MapData (facebook#3155) Summary: Pull Request resolved: facebook#3155 Differential Revision: D66945078
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
… rate for MapData (facebook#3106) Summary: Pull Request resolved: facebook#3106 This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Differential Revision: D66366076 Reviewed By: Balandat
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
facebook#3112) Summary: Pull Request resolved: facebook#3112 * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
4523b8a to
50896d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
facebook#3112) Summary: Pull Request resolved: facebook#3112 * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
ltiao
force-pushed
the
export-D66434621
branch
from
50896d4 to
15d6240
Compare
facebook#3112) Summary: Pull Request resolved: facebook#3112 * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
|
This pull request was exported from Phabricator. Differential Revision: D66434621 |
ltiao
force-pushed
the
export-D66434621
branch
from
15d6240 to
cad9e38
Compare
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 17, 2024
…a, [Ax][WIP/Not Ready] Putting it all together (subclass TorchModelBridge) (facebook#3112) Summary: Pull Request resolved: facebook#3112 * Provide a new method `latest` for `MapData` to retrieve the *n* most recently observed values for each (arm, metric) group, determined by the `map_key` values, where higher implies more recent. * Update `observations_from_data` to optionally utilize `latest` and retain only the most recently observed *n* values (the new option, if specified alongside the existing subsampling options, will now take precedence). * Modify the "upcast" `MapData.df` property to leverage `latest`, which is a special case with *n=1*. * Revise the docstring to reflect changes in the pertinent methods, as well as update related methods like `subsample` to ensure uniform and consistent writing. Differential Revision: D66434621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D66434621