Include progression information as metadata when transforming Data to Observations #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3001 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 493 493
Lines 49949 49934 -15
=======================================
- Hits 47662 47649 -13
+ Misses 2287 2285 -2 ☔ View full report in Codecov by Sentry. |
ltiao
force-pushed
the
export-D65255312
branch
from
ceb2293 to
f81fb7a
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 4, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 Differential Revision: D65255312
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 4, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
f81fb7a to
df30af6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
force-pushed
the
export-D65255312
branch
from
df30af6 to
b935f7b
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 5, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 5, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
b935f7b to
53b9e96
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 5, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 7, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Nov 8, 2024
… Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
53b9e96 to
854fc50
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 22, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 23, 2024
… Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 25, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Nov 25, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
854fc50 to
8f94586
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 4, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 5, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
force-pushed
the
export-D65255312
branch
from
7c23f6a to
bc87514
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 9, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 9, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 9, 2024
…ta to Observations (facebook#3001) Summary: This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
bc87514 to
a7d41a3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
a7d41a3 to
3c5642d
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
3c5642d to
4a2967d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Dec 12, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
ltiao
force-pushed
the
export-D65255312
branch
from
4a2967d to
d8b5711
Compare
…ationFeature (facebook#3023) Summary: Pull Request resolved: facebook#3023 **Context:** The values corresponding to map keys are propagated as part of the ObservationFeatures' `metadata` dict field. We require a way to place it in the `parameters` dict field so that it can be used later on. This generalized transform is able to take user-specified entries from an `ObservationFeatures`'s `metadata` field and place it within its `parameters` field, and update the search space accordingly to reflect this. This implements a new transform, `MetadataToFloat`, that extracts specified fields from each `ObservationFeature` instance's metadata and incorporates them as parameters. Furthermore, it updates the search space to include the specified field as a `RangeParameter` with bounds determined by observations provided during initialization. This process involves analyzing the metadata of each observation feature and identifying relevant fields that need to be included in the search space. The bounds for these fields are then determined based on the observations provided during initialization. Differential Revision: D65430943
… that provides sensible defaults for MapData (facebook#3155) Summary: Pull Request resolved: facebook#3155 This adds a specialization of the `MetadataToFloat` Transform, `MapKeyToFloat`, that provides sensible default settings to allow for intercepting map metric data appearing in the ObservationFeatures' metadata. Additionally, for the purposes of specifying `fixed_features` down the line, when `_transform_observation_feature` is given an empty `ObservationFeatures` (more specifically, an `ObservationFeatures` with an empty `parameters` dict), it will populate it with the *upper bound* associated with each metadata key. Differential Revision: D66945078
… rate for MapData (facebook#3106) Summary: Pull Request resolved: facebook#3106 This refines the logic for calculating per-metric subsampling rates in `MapData.subsample` and incorporates a (probably premature) performance optimization, achieved by utilizing binary search on a sorted list instead of linear search. Differential Revision: D66366076 Reviewed By: Balandat
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Reviewed By: saitcakmak Differential Revision: D65255312
|
This pull request was exported from Phabricator. Differential Revision: D65255312 |
ltiao
force-pushed
the
export-D65255312
branch
from
d8b5711 to
4fba225
Compare
ltiao
pushed a commit
to ltiao/Ax
that referenced
this pull request
Dec 17, 2024
…ta to Observations (facebook#3001) Summary: Pull Request resolved: facebook#3001 This updates `observations_from_data` to include progression info as observation feature metadata by default. More specifically: - Updates `observations_from_data` to subsume behavior of `observations_from_map_data` as special case. - Updates calls to `observations_from_map_data` to instead call `observations_from_data` - Removes `observations_from_map_data` which is used exclusively by `MapTorchModelBridge` Differential Revision: D65255312 Reviewed By: saitcakmak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D65255312