ReductionCriterion to inherit from FuncEnum` (which will help it play well with serialization and storage)
#2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63914987 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2915 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 504 504
Lines 49531 49559 +28
=======================================
+ Hits 47395 47422 +27
- Misses 2136 2137 +1 ☔ View full report in Codecov by Sentry. |
lena-kashtelyan
force-pushed
the
export-D63914987
branch
from
0e9460f to
f6e35d1
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Oct 24, 2024
…ay well with serialization and storage) (facebook#2915) Summary: As titled, applying the new `FuncEnum` util Reviewed By: mgarrard Differential Revision: D63914987
|
This pull request was exported from Phabricator. Differential Revision: D63914987 |
…ay well with serialization and storage) (facebook#2915) Summary: As titled, applying the new `FuncEnum` util Reviewed By: mgarrard Differential Revision: D63914987
lena-kashtelyan
force-pushed
the
export-D63914987
branch
from
f6e35d1 to
b7fe72c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63914987 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled, applying the new
FuncEnumutilReviewed By: mgarrard
Differential Revision: D63914987