Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7983: Handled previewing ezimage field with height of 0 #2117

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Mar 26, 2024

Question Answer
Tickets IBX-7983
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Division by 0 is impossible, hence, the change.

.avif files in later PHP versions should be handled properly by the getimagesize method (since PHP 8.1 RC3), but we still have to handle older files somehow (dimension values are stored in .xmls in a database).

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

Copy link
Member

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance that height will be e.g. 0.00 or 0 perhaps? I was wondering if any sanitization/casting on the backend side makes sense.

@konradoboza konradoboza requested a review from a team March 26, 2024 14:48
@barw4
Copy link
Member Author

barw4 commented Mar 27, 2024

@barw4 barw4 requested a review from Steveb-p April 16, 2024 11:33
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk mikadamczyk merged commit ef36131 into 2.3 Apr 17, 2024
13 checks passed
@mikadamczyk mikadamczyk deleted the ibx-7983-fix-displaying-ezimage-avif-field branch April 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.