IBX-6540: Added Depth sort to breadcrumbs #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dawid Parafiński <[email protected]>
konradoboza
approved these changes
Mar 1, 2024
mikadamczyk
approved these changes
Mar 4, 2024
Co-authored-by: Mikolaj Adamczyk <[email protected]>
|
tomaszszopinski
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDW columns are currently ordered based on the sequence of breadcrumbs in AccordionData. Typically, everything ran smoothly when utilizing IDs associated with deeper levels in the tree structure, where nested elements consistently had higher IDs than their parent counterparts. However, inconsistencies emerged in some cases, particularly when IDs did not follow this pattern. This issue is likely to recur in UDW if locations are moved.
The problem surfaced on Postgres, where the default sort order does not rely on IDs.
Proposing a solution by sorting columns based on depth, ensuring consistent breadcrumb order. There may be debates about whether JS/UDW should handle this, but I believe it's acceptable.
Checklist:
$ composer fix-cs)