-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/vite (front end) build #43
Conversation
@sloan58 The problem still exists. The tests fail. |
That's interesting. If you check the actions that ran when I pushed yesterday they all passed. I see that you adjusted the |
I think we need to leave this in there. If there's no package.json file, we shouldn't build. My local tests fail as well on the current codebase if I delete package.json
|
I agree with you. After making the adjustments, but the tests failed. The |
With my latest commit I was able to build an image with or without a package.json file. Maybe there should be two additional tests (two with and two without package.json for swoole and rr)? |
That's true. But I removed it to test that the build stage works correctly. |
I guess I'm not sure why we updated the |
By using the |
Understood. If there's no package.json file we shouldn't run npm run build as it will fail. If we want to test the case that package.json doesn't exist, we could have two more tests that delete package.json prior to building the image. |
Ahhhhhh, the |
Awesome! Thanks for the help getting this merged! |
If npm dependencies exist (package.json or package-lock.json), build front end assets.