-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vite builds #41
Conversation
The Docker image build fails with this error:
|
After adding NODE_ENV=production, mine fails because it's not able to find vite, though I don't get an error about package.json. Do you have a package.json in your Laravel project? This works for me:
tbh, I don't set NODE_ENV=production when building. Since the intermediate build is not included in the final image and we get the prod build in public, is it necessary to include those statements? |
Thank you for your assistance! I have attempted several times to run the code on my machine and via GitHub actions, but I kept encountering the same error. I want to clarify that I have already made sure that the Nevertheless, I will give it another try and see if I can resolve the issue. As a best practice for Dockerizing Node apps, I had previously set |
np! Glad to try and help. This package is awesome. Yes, I was not checking for package.json in my PR, which should be done. Assuming everyone has one isn't safe, even if it comes standard today with a I can adjust my PR and resubmit with the check for package.json and also NODE_ENV removed if you'd like? |
I appreciate it. Feel free to adjust your PR and resubmit it with the necessary changes. |
No description provided.