Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure each external command exists with success code #363

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make sure each external command exists with success code #363

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a917f8
[feature] assure that each external command exists with success code
marmoure Sep 2, 2024
1537d88
[feature] throw when an error happens
marmoure Sep 4, 2024
b757d24
[bugfix] rename processCode to exitCode
marmoure Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 36 additions & 7 deletions plugin-release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,21 +99,46 @@ module.exports = {
packageFiles.push(`${projectWorkspace.cwd}/package.json`);
}

// process exit code for the last command
let exitCode = 0;

// Step 4 - git commit the version update.
this.context.stdout.write(`4. git Committing the version update...\n`);
await execute('git', ['commit', `--message=[release] Release version: ${this.version}`].concat(packageFiles), executeOptions);

exitCode = await execute('git', ['commit', `--message=[release] Release version: ${this.version}`].concat(packageFiles), executeOptions);
if (exitCode !== 0) {
this.context.stdout.write(`Error: git commit failed with code: ${exitCode}\n`);
return;
} else {
this.context.stdout.write(`git commit OK!\n`);
}

// Step 5 - git tag and sign the release tag.
this.context.stdout.write(`5. git Committing the version update...\n`);
await execute('git', ['tag', `--message=[release] Release version: ${this.version}`, '--sign', `v${this.version}`], executeOptions);

exitCode = await execute('git', ['tag', `--message=[release] Release version: ${this.version}`, '--sign', `v${this.version}`], executeOptions);
if (exitCode !== 0) {
this.context.stdout.write(`Error: git tag failed with code: ${exitCode}\n`);
return;
} else {
this.context.stdout.write(`git tag OK!\n`);
}
// Step 6 - git push the updates.
this.context.stdout.write(`6. git push the version update...\n`);
this.context.stdout.write(`6.1. git pushing the branch...\n`);
await execute('git', ['push'], executeOptions);
exitCode = await execute('git', ['push'], executeOptions);
if (exitCode !== 0) {
this.context.stdout.write(`Error: git push failed with code: ${exitCode}\n`)
return;
} else {
this.context.stdout.write(`git push OK!\n`);
}
this.context.stdout.write(`6.2. git pushing the tag...\n`);
await execute('git', ['push', '--tags'], executeOptions);

exitCode = await execute('git', ['push', '--tags'], executeOptions);
if (exitCode !== 0) {
this.context.stdout.write(`Error: git push tags failed with code: ${exitCode}\n`);
return;
} else {
this.context.stdout.write(`git push tags OK!\n`);
}
// Step 7 - Publish the packages to npm.js.
this.context.stdout.write(`7. Running \`yarn npn publish\` to publish packages to npm.js...\n`);
await this.cli.run(['npm', 'login']);
Expand All @@ -137,6 +162,10 @@ module.exports = {

this.context.stdout.write(`Released version: ${this.version} OK!\n`);
}

async catch(error) {
throw error;
}
}

return {
Expand Down