Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/14 add specific function to register an event or command to a service #18

Conversation

debae
Copy link
Contributor

@debae debae commented Aug 8, 2024

Motivation

Added function to link a message ( event / command ) directly to a service.

@debae debae requested a review from boyney123 as a code owner August 8, 2024 19:38
Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: a042477

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eventcatalog/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@boyney123
Copy link
Contributor

Thanks @debae , fixed a few comments in the docs, and also added some tests for addCommandToService.

I see the API does not check to see if the command or event is there in the catalog, maybe that is something we can add in the future, but for initial release this seems OK to me!

Thanks for the contributions!

@boyney123 boyney123 merged commit a8724d9 into event-catalog:main Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants