fix(core): splitting target path while coping content files

[devpsk]

Hi,

I noticed a bug when executing the command: npm run build aka (eventcatalog build). When I try to build the production version of the catalog, one of my application/microservice disappears. The application that disappears in the production environment (everything works on localhost) is the one named external-services-builder

During analysis, I found that the method getTargetPath is losing my name. The directory where Event Catalog places applications is services and my application / microservice also contains the word "services" (external-services-builder). So after calling the method "getTargetPath," an incorrect path is generated, which causes the application not to appear in the menu at all.

I analyzed the change history in the file scripts/catalog-to-astro-content-directory.js and noticed that it used to work previously. I restored that one code fragment.

[changeset-bot]

⚠️ No Changeset found

Latest commit: e566f06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[carlosallexandre]

The / was removed for compatibility with win32 plataform.
Maybe path.sep could works 🤷🏼‍♂️.

When I worked at a refactor proposal for the catalog-to-astro-content-directory.js I got the following for this snippet:

/**
 * Generates the path until the ASTRO_COLLECTION_KEY or the PROJECT_DIR root.
 * @param {string} filePath The path to the file.
 * @returns {string} The path until the COLLECTION_KEY or PROJECT_DIR root.
 */
const getRelativeTargetPath = (filePath) => {
  const filePathParsed = path.parse(filePath);
  const fileDir = filePathParsed.dir.split(path.sep).filter(Boolean);

  const relativePath = [];
  for (let i = fileDir.length - 1; i >= 0; i--) {
    relativePath.unshift(fileDir[i]);
    if (isCollectionKey(fileDir[i])) break;
  }

  return path.join(...relativePath, filePathParsed.base);
};

/**
 * Check if the key is an ASTRO COLLECTION KEY
 * @param {string} key
 * @returns {boolean}
 */
const isCollectionKey = (key) => {
  const COLLECTION_KEYS = ['commands', 'domains', 'events', 'pages', 'services', 'teams', 'users'];
  /** 
   *  Using includes won't works for your use case either
   *  The solution will be a comparison
   */
  return COLLECTION_KEYS.includes(key);
};

You can check the implementation here.
I hope this can help you find a suitable solution.

[devpsk]

Thanks @carlosallexandre for review. I committed new changes, can you check?