Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device lifecycle #16513

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add device lifecycle #16513

wants to merge 2 commits into from

Conversation

andig
Copy link
Member

@andig andig commented Oct 5, 2024

Replaces #11572. Custom devices use device names for logging (only modbus, http and mqtt plugins for time being).

@andig andig added infrastructure Basic functionality backlog Things to do later labels Oct 5, 2024
@andig andig changed the title Add device lifecycles and use device names for logging Add device lifecycle and use device names for logging Oct 5, 2024
@andig andig changed the title Add device lifecycle and use device names for logging Add device lifecycle Oct 5, 2024
@GrimmiMeloni
Copy link
Sponsor Collaborator

GrimmiMeloni commented Oct 7, 2024

I am a bit confused. I see the intention (logging with better names), but I fail to see the "lifecycle" aspect. A few words on what a "device lifecycle" is would be helpful and appreciated.

@andig andig added the needs decision Unsure if we should really do this label Oct 7, 2024
@andig
Copy link
Member Author

andig commented Oct 7, 2024

Ah, sorry. Once we have the context in place we can add it to the device, including cancel capability. That will be the handle and goish way to terminate a running device. This PR just provides the infrastructure. Replaced PR has some examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Things to do later infrastructure Basic functionality needs decision Unsure if we should really do this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants