Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.69 - Renaming the patch endpoint for setting the loan officer #192

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 3, 2024

There is one patch path to set the loan officer itself and one to set the loan officer contact details. However, both paths contain the term "Ansprechpartner" in the sense of the contact person on the loan provider side. However, the "Ansprechpartner" actually means the person on the sales side (clerk). This ambiguity is hereby resolved.

Set loan officer

PATCH /v2/antraege/ABC12F/1/1 HTTP/1.1
Host: baufismart.api.europace.de
Content-Type: application/json
Authorization: Bearer {{access-token}}
Content-Length: 116

[
    {
        "op": "replace",
        "path": "/kreditSachbearbeiter/partnerId",
        "value": "XYZ55"
    }
]

Set loan office contact details

PATCH /v2/antraege/ABC12F/1/1 HTTP/1.1
Host: baufismart.api.europace.de
Content-Type: application/json
Authorization: Bearer {{access-token}}
Content-Length: 263

[
    {
        "op": "replace",
        "path": "/kreditSachbearbeiter/externerPartner",
        "value": {
            "kreditBetriebPartnerId": "MYID03",
            "name": "Frau Angela Anaconda", 
            "telefonnummer": "0170 7717789"
        }
    }
]

The old patch paths /ansprechpartner/partnerId and /ansprechpartner/externerPartner are deprecated. They can still be used, but will be removed in a future major release.

@github-actions github-actions bot requested a review from a team as a code owner April 3, 2024 14:22
@unstko unstko changed the title Update der Dokudatei(en) Release 2.69 - Renaming the patch endpoint for setting the loan officer Apr 3, 2024
Copy link

@HypoStephan HypoStephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unstko unstko merged commit 31238f6 into master Apr 4, 2024
1 check passed
@unstko unstko deleted the publish/03-04-24_16-22-37 branch April 4, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants