Remove tf subscription #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeyoung-Lim
force-pushed
the
pr-fix-planning-panel
branch
from
e4bff87
to
6209309
Compare
Publish gridmap info using grid_map_geo_msgs Set map origin info from subscribed map
Jaeyoung-Lim
force-pushed
the
pr-fix-planning-panel
branch
from
80e1f38
to
43529eb
Compare
Claudio-Chies
requested changes
Apr 9, 2024
| @@ -73,6 +73,7 @@ class PlanningPanel : public rviz::Panel { | |||
| void targetAngleCallback(const std_msgs::Float64& msg); | |||
| void snowDepthCallback(const std_msgs::Float64& msg); | |||
| void sspStateCallback(const std_msgs::Int8& msg); | |||
| void mapInfoCallback(const std_msgs::Float64& msg); | |||
There was a problem hiding this comment.
shouldnt this be
void mapInfoCallback(const grid_map_geo_msgs::GeographicMapInfo& msg)
i get the build error that no declaration found in line 316 at plannting_panel.cpp
and then i also had to add the import
#include "grid_map_geo_msgs/GeographicMapInfo.h"
There was a problem hiding this comment.
Added a commit, which resolves the issue. Now it is ready to merge.
Tried and tested
There was a problem hiding this comment.
Ah wait, strange I thought I did that but thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
This PR subscribes to gridmap information being published with
grid_map_geo_msgs.This PR requries ethz-asl/grid_map_geo#62