Implement pectra devnet-5 spec #3807
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
jochem-brouwer
added
PR state: needs review
PR/Issue state: blocked
and removed
PR state: WIP
labels
|
Have added a review+blocked label, I suggest we use this PR as devnet-5 branch until devnet-4 is taken offline. |
|
Devnet-4 is deleted, so we can now merge Devnet-5 changes into master, have removed blocked label. |
|
Ah ok tests failing, will fix tomorrow (likely block hashes / request hashes since those have changed) |
| // TODO: verify that this is the correct designator | ||
| // The PR https://github.com/ethereum/EIPs/pull/8969 has two definitions of the | ||
| // designator: the original (0xef0100) and the designator added in the changes (0xef01) | ||
| const eip7702Designator = hexToBytes('0xef01') |
There was a problem hiding this comment.
Just confirming my thinking. These only get computed once at run time, right? They aren't recomputed every single time we access this code are they?
There was a problem hiding this comment.
Only computed once! Can also move it somewhere else like types.ts.
|
Have converted this back to "draft" and added blocked label again. This will be our prep-branch for devnet-5. Our master branch will currently support devnet-4 (even though devnet-4 is now nuked). The reason is that the Mekong testnet is devnet-4 specced: https://notes.ethereum.org/@ethpandaops/mekong#Which-versionbranch-do-I-use and it is still up. Point all devnet-5 related PRs to this PR :) (branch |
|
changed for ethereum/execution-apis#574 are now in the branch |
g11tech
changed the title
* common/evm/vm: implement EIP7623 calldata cost increase * move the floorcost update and add debug log * fix t8ntool empty requests reporting * common: add 7623 * tx: add 7623 validator * t8n: throw on invalid txs * make cspell happy --------- Co-authored-by: harkamal <[email protected]>
jochem-brouwer
force-pushed
the
devnet-5
branch
from
0d7e696 to
5079664
Compare
This PR incorporates the changes of EIP-7702 and EIP-7685 for devnet-5 as outlined in: https://notes.ethereum.org/@ethpandaops/pectra-devnet-5
ethereum/EIPs#8969
ethereum/EIPs#8989
ethereum/execution-apis#574
Will keep this PR as draft, because the 7702 changes might get a follow-up PR (regarding the designator, see: ethereum/EIPs#8969 (comment))Just got convinced that this is not a problem and we should stick to0xef01as "code" when reading from delegated accounts