-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Monitor crashing regularly, small additional fixes #1669
base: staging
Are you sure you want to change the base?
Conversation
Because it was throwing, monitor was shutting off itself
Why shouldn't we throw in that place? |
@manuelwedler Why should we? The monitor was able to successfully assemble the contract and send a request to the Sourcify server. It's a problem either on the network (probably this in our case) or an error of the Sourcify server. I don't think this should stop the Monitor from running. We already log an error and actually we need to pay attention to that if there's an increase in errors. This wouldn't work now as we have plenty of these errors and need to fix it first. |
I agree with @kuzdogan that the monitor should not be stopped for that error. When I implemented it I was confused by the try-catch at the top of the callstack sourcify/services/monitor/src/ChainMonitor.ts Lines 78 to 106 in 460fc8c
Since this is an event being triggered, the error it's not catched. Instead of not throwing, I think it makes more sense to add another try-catch inside |
Okay makes sense to me. I didn't understand that the monitor was crashing for it. Thanks for explaining. |
Is this good to go? I need an approval |
I think it still makes sense to address this |
Yeah I missed the lower part of that comment. But I don't really understand the point there.
Where's the event? The event mechanism is inside the |
The Monitors were crashing because we were throwing here
sourcify/services/monitor/src/ChainMonitor.ts
Lines 348 to 351 in 33cc02e