Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how-to-create-locks.md #808

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Update how-to-create-locks.md #808

merged 1 commit into from
Jun 13, 2024

Conversation

wenjiaswe
Copy link
Contributor

Part of KubeCon EU 24 doc sprint

#794

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wenjiaswe - Looks good, we just need to make the same changes for 3.5 version of the file also.

Edit: Also please ensure commit is signed 😄

Signed-off-by: Wenjia Zhang <[email protected]>
@wenjiaswe
Copy link
Contributor Author

@jmhbnz finally get back to this PR... Really sorry for the long wait, please kindly help to review again.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @wenjiaswe

@jmhbnz jmhbnz merged commit 64b98a4 into main Jun 13, 2024
5 checks passed
@jmhbnz jmhbnz deleted the wenjiaswe-patch-1 branch July 19, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants