Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix MustNewMember #18584

Closed
wants to merge 3 commits into from

Conversation

clement2026
Copy link
Contributor

@clement2026 clement2026 commented Sep 13, 2024

The original MustNewMember function creates a new member without using the specific PeerURLs, causing the leader to fail when sending snapshots to the new member through those PeerURLs.

This PR fixes the MustNewMember by overriding the new member’s PeerURLs.

#18494 depends on this PR

Part of #17098

@k8s-ci-robot
Copy link

Hi @clement2026. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clement2026 clement2026 changed the title Fix TestMemberPromote tests: fix TestMemberPromote Sep 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (981061a) to head (c381070).

Current head c381070 differs from pull request most recent head d975a1e

Please upload reports for the commit d975a1e to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18584      +/-   ##
==========================================
+ Coverage   68.73%   68.77%   +0.04%     
==========================================
  Files         420      420              
  Lines       35474    35474              
==========================================
+ Hits        24382    24399      +17     
+ Misses       9666     9655      -11     
+ Partials     1426     1420       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981061a...d975a1e. Read the comment docs.

@clement2026 clement2026 changed the title tests: fix TestMemberPromote tests: fix MustNewMember Sep 13, 2024
Signed-off-by: Clement <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clement2026, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member

/cc @ahrtr

Signed-off-by: Clement <[email protected]>
m.PeerURLs = urls
var listeners []net.Listener
for _, url := range urls {
l, err := transport.NewListener(url.Host, url.Scheme, nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last parameter always nil? What if it's HTTPS communication?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tlsinfo *transport.TLSInfo param to MustNewMember() in case callers need it.

@clement2026 clement2026 deleted the fix-TestMemberPromote branch September 24, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants