Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Add entry for etcdutl hashkv command. #18460

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

mello369
Copy link
Contributor

Issue : #15061

@k8s-ci-robot
Copy link

Hi @mello369. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @mello369! Just one minor suggestion below if you have time 🙏🏻

/ok-to-test

CHANGELOG/CHANGELOG-3.6.md Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (62e4433) to head (7a7127a).

Current head 7a7127a differs from pull request most recent head e653d1e

Please upload reports for the commit e653d1e to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18460      +/-   ##
==========================================
+ Coverage   68.79%   68.89%   +0.09%     
==========================================
  Files         420      420              
  Lines       35490    35490              
==========================================
+ Hits        24416    24451      +35     
+ Misses       9647     9616      -31     
+ Partials     1427     1423       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e4433...e653d1e. Read the comment docs.

@mello369
Copy link
Contributor Author

Thanks for taking care of this @mello369! Just one minor suggestion below if you have time 🙏🏻

/ok-to-test

Thanks for the suggestion @jmhbnz. Updated!

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mello369

@mello369
Copy link
Contributor Author

@jmhbnz forgive me for the naive question, but do I need other approvals on this PR?

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, mello369

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz
Copy link
Member

jmhbnz commented Aug 19, 2024

@jmhbnz forgive me for the naive question, but do I need other approvals on this PR?

Normally we leave things open a bit for second pair of eyes in case a reviewer misses something. Thanks @ahrtr for additional review, merging now.

@jmhbnz jmhbnz merged commit 7593e79 into etcd-io:main Aug 19, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants