Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32S3: Make an array out of touch_pad #273

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

playfulFence
Copy link
Contributor

Related to: esp-rs/esp-hal#1905

@playfulFence
Copy link
Contributor Author

@jessebraham
It turned out that on ESP32 the layout of fields in registers TOUCH_PAD8 and TOUCH_PAD9 differs from the layout in TOUCH_PAD0-7. Thus, the changes for esp32 become irrelevant and I don't see a reasonable way how to merge them. The changes in this PR now only apply to esp32s3.

Thanks for your review, by the way! Thanks to it, I've been poking around to see why it doesn't work to use _array for esp32, which is why I found the difference in field layouts

@playfulFence playfulFence changed the title ESP32 and ESP32S3: Make an array out of touch_pad ESP32S3: Make an array out of touch_pad Aug 21, 2024
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, it's fine to just fix what is relevant right now. Thanks for the explanation and for cleaning this up!

@jessebraham jessebraham merged commit 045d2d9 into esp-rs:main Aug 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants