Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esp-hal-buzzer to drive a piezo-electric buzzer. #3

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

AnthonyGrondin
Copy link
Collaborator

Moved over the esp-hal-buzzer package from esp-rs/esp-hal#1984

The provided example currently builds using a patch for esp-hal.

I'll put this in draft until esp-rs/esp-hal#1984 is merged so that we can update the patch to use the upstream repository

@jessebraham
Copy link
Member

Thanks for moving this PR over! esp-rs/esp-hal#1984 has now been merged :)

@AnthonyGrondin AnthonyGrondin marked this pull request as ready for review September 17, 2024 14:33
@AnthonyGrondin
Copy link
Collaborator Author

I've updated the patch to use the upstream repo and added CI tests.

I also added alias in .cargo/config.toml so the example can be flashed with:
cd esp-hal-buzzer/ && cargo +esp esp32s3 --example buzzer

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for this PR, glad to finally be able to merge it! 😅 I've added you as a maintainer to the repository (for CODEOWNER purposes) and this all looks good to me.

@jessebraham jessebraham merged commit 5863f99 into esp-rs:main Sep 17, 2024
7 checks passed
@AnthonyGrondin
Copy link
Collaborator Author

Thank you. I'm glad to see the buzzer saga resolved 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants