Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ensure all rules are exported #53

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Nov 8, 2024

Prerequisites checklist

What is the purpose of this pull request?

Ensures that all rules available in src/rules are exported in plugin.rules. Also adds a test for plugin configs that would fail if, for example, the config enables a non-existent rule.

What changes did you make? (Give an overview)

Added tests.

Related Issues

#51

Is there anything you'd like reviewers to focus on?

If this looks good, I'll add similar tests to @eslint/markdown and @eslint/css. Edit: list of rules and recommended config are autogenerated in @eslint/markdown, so there's no need for tests there.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@mdjermanovic mdjermanovic merged commit e29e94c into main Nov 12, 2024
15 checks passed
@mdjermanovic mdjermanovic deleted the test-export-all-rules branch November 12, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants