feat: Prerender sponsors for READMEs #638
Conversation
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I will make the requested changes. |
|
@amareshsm are you still working on this? |
Yes, I will push the request changes in some time. |
includes/generate-sponsors.js
Outdated
| <p>${sponsors | ||
| .map( | ||
| sponsor => | ||
| `<a href="${sponsor.url || "#"}"><img src="${ |
There was a problem hiding this comment.
There are sponsors for whom image might not exist as well. We might want to handle that? In the PR generated sponsors.md I was able to see one sponsor without image?
There was a problem hiding this comment.
When I checked, I didn’t see a broken image icon. I will look it in this again.
There was a problem hiding this comment.
The logo isn't missing on the website, and that's using the same data, so I'm not sure why this is creating a missing image. 🤔
There was a problem hiding this comment.
Perhaps you were using an old data file. Rebasing this branch and running the script again to regenerate sponsors.md might fix this.
includes/generate-sponsors.js
Outdated
| const SPONSORS_URL = path.resolve(__dirname, "../src/_data/sponsors.json"); | ||
| const TECH_SPONSORS_URL = path.resolve( |
There was a problem hiding this comment.
Can we rename these to SPONSORS_FILE_PATH and TECH_SPONSORS_FILE_PATH as these are not URLs but file paths? Also, can we rename fetch* functions to read* as they're not fetching data from URLs but reading files?
|
@nzakas in #638 (comment), did you mean that the generated file should be |
Co-authored-by: Milos Djermanovic <[email protected]>
Yes, it seems that the generated file should be placed inside the |
Co-authored-by: Nicholas C. Zakas <[email protected]>
| @@ -9687,42 +9726,6 @@ | |||
| "url": "https://github.com/sponsors/ljharb" | |||
| } | |||
| }, | |||
| "node_modules/got": { | |||
There was a problem hiding this comment.
Any idea why this was removed? The only change in package.json dependencies was adding common-tags, which doesn't have any dependencies.
Prerequisites checklist
What is the purpose of this pull request?
Prerender sponsors for READMEs
What changes did you make? (Give an overview)
I added a script that retrieves sponsor data from JSON files and formats it into HTML sections for a markdown file. This script categorizes sponsors by tier and incorporates technology sponsors with their respective images. It then saves the formatted content to a new markdown file,
sponsors.md, which we will utilize in our other repositories.Related Issues
#619
Is there anything you'd like reviewers to focus on?
Please let me know if this approach works and I'm open to any suggestions/changes.