Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: generic Show #85

Merged
merged 3 commits into from
Sep 24, 2023
Merged

Conversation

kindaro
Copy link
Contributor

@kindaro kindaro commented Jul 20, 2023

This feature was requested in #40 and later in #78 but was never implemented. Maybe owing to Show not being a derivable type class in PureScript. However, for types that are instances of Generic there is genericShow in the standard library, so I am wielding that.

Thanks to Colin @fosskers for blazing the trail.

Closes #78, ping @flip111.

@fosskers
Copy link
Contributor

Lord it's been years. Thanks for finally putting this together.

@flip111
Copy link

flip111 commented Jul 23, 2023

Thanks a lot @kindaro great work !

@kindaro
Copy link
Contributor Author

kindaro commented Sep 12, 2023

Ping @eskimor?

@eskimor eskimor merged commit d947035 into eskimor:master Sep 24, 2023
7 checks passed
@peterbecich peterbecich mentioned this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eq/Ord/Show instances
4 participants