feat(pipeline): inject project/org default namespace for ci/cd pipeline #6443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfwn
requested changes
Sep 25, 2024
| @@ -95,6 +95,11 @@ func (e *Endpoints) pipelineCreate(ctx context.Context, r *http.Request, vars ma | |||
| if err != nil { | |||
| return errorresp.ErrResp(err) | |||
| } | |||
|
|
|||
| // also add project/org default config namespace | |||
| reqPipeline.ConfigManageNamespaces = append(reqPipeline.ConfigManageNamespaces, makeProjectDefaultLevelCmsNs(app.ProjectID)...) | |||
There was a problem hiding this comment.
project namespace should be placed after org namespace, for priority reason.
chengjoey
force-pushed
the
feat/add-default-ns
branch
from
98e8a30
to
a113a8e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6443 +/- ##
=======================================
Coverage 15.62% 15.62%
=======================================
Files 3674 3674
Lines 311601 311609 +8
=======================================
+ Hits 48675 48686 +11
+ Misses 257466 257462 -4
- Partials 5460 5461 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfwn
approved these changes
Sep 25, 2024
|
/approve |
erda-bot
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
inject project/org default namespace for ci/cd pipeline
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.