feat(translator): implement access log types #4341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4341 +/- ##
==========================================
+ Coverage 65.72% 65.79% +0.06%
==========================================
Files 200 200
Lines 24125 24148 +23
==========================================
+ Hits 15856 15887 +31
+ Misses 7135 7126 -9
- Partials 1134 1135 +1 ☔ View full report in Codecov by Sentry. |
zirain
reviewed
Sep 27, 2024
internal/xds/translator/testdata/in/xds-ir/accesslog-als-tcp.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Guy Daich <[email protected]>
zirain
approved these changes
Oct 4, 2024
arkodg
reviewed
Oct 8, 2024
| telemetry: | ||
| accessLog: | ||
| settings: | ||
| - type: Listener |
There was a problem hiding this comment.
so this is a override style setting ? i.e. since a Route type is not defined, the define Route AccessLog setting is applied ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #3600