Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement RequestTimeout in BackendTrafficPolicy #4329

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sanposhiho
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

implement RequestTimeout in BackendTrafficPolicy

Which issue(s) this PR fixes:

Fixes #3251

@sanposhiho sanposhiho requested a review from a team as a code owner September 25, 2024 04:16
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.76%. Comparing base (69bf882) to head (087d441).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/clustersettings.go 76.92% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4329      +/-   ##
==========================================
- Coverage   67.94%   65.76%   -2.18%     
==========================================
  Files         190      200      +10     
  Lines       23113    24133    +1020     
==========================================
+ Hits        15704    15871     +167     
- Misses       6287     7129     +842     
- Partials     1122     1133      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Oct 8, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team October 8, 2024 03:37
@arkodg
Copy link
Contributor

arkodg commented Oct 8, 2024

hey can you run make generate and commit those changes ?

@sanposhiho
Copy link
Contributor Author

oops, done 🙏

@sanposhiho sanposhiho requested a review from arkodg October 8, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting to override default request timeout
2 participants