ci: dual-stack support for kind cluster #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4301 +/- ##
=======================================
Coverage 65.68% 65.68%
=======================================
Files 197 197
Lines 23565 23565
=======================================
Hits 15478 15478
Misses 6979 6979
Partials 1108 1108 ☔ View full report in Codecov by Sentry. |
zirain
reviewed
Sep 22, 2024
zirain
changed the title
zirain
previously approved these changes
Sep 22, 2024
zhaohuabing
reviewed
Sep 23, 2024
Signed-off-by: Juwon Hwang (Kevin) <[email protected]>
Signed-off-by: Juwon Hwang (Kevin) <[email protected]>
Signed-off-by: Juwon Hwang (Kevin) <[email protected]>
zirain
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: dual-stack support for kind cluster
What type of PR is this?
feat: Add dual-stack (IPv4 and IPv6) support for kind cluster
What this PR does / why we need it:
This PR implements dual-stack (IPv4 and IPv6) support for our kind cluster setup. It modifies the
create-cluster.shscript to enable both IPv4 and IPv6 networking in the kind cluster and configures MetalLB to use address pools for both protocols. This enhancement allows for testing and development in environments that require both IP protocols, improving our cluster's versatility and compatibility with modern network configurations.Key changes:
Which issue(s) this PR fixes:
Related #184
Additional context:
This change modifies the
tools/hack/create-cluster.shscript to:ipFamily: dualto the kind cluster configurationThese modifications ensure that our development environment can support and test dual-stack networking scenarios, which is crucial for modern Kubernetes deployments and aligns with the goals outlined in issue #184.