Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gateway API 1.2.0] Upgrade Gateway API to 1.2.0-rc2 #4270

Merged
merged 18 commits into from
Oct 1, 2024

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Sep 17, 2024

implement: #4269

GatewayInfrastructure has been disabled and tracked with the issue: #4330

@zhaohuabing zhaohuabing requested a review from a team as a code owner September 17, 2024 23:58
@zhaohuabing zhaohuabing marked this pull request as draft September 17, 2024 23:58
@zirain

This comment was marked as off-topic.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.02%. Comparing base (e2272df) to head (eb2ff05).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/route.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4270      +/-   ##
==========================================
+ Coverage   65.98%   66.02%   +0.03%     
==========================================
  Files         197      197              
  Lines       23972    23996      +24     
==========================================
+ Hits        15819    15844      +25     
  Misses       7026     7026              
+ Partials     1127     1126       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing force-pushed the gateway-api-upgrade branch 2 times, most recently from 1b20f32 to 84b4bd4 Compare September 25, 2024 07:32
@zhaohuabing zhaohuabing changed the title upgrade Gateway API to 1.2.0 [Gateway API 1.2.0]upgrade Gateway API to 1.2.0 Sep 25, 2024
@zhaohuabing zhaohuabing changed the title [Gateway API 1.2.0]upgrade Gateway API to 1.2.0 [Gateway API 1.2.0] Upgrade Gateway API to 1.2.0 Sep 25, 2024
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing marked this pull request as ready for review September 26, 2024 04:45
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
@zirain zirain changed the title [Gateway API 1.2.0] Upgrade Gateway API to 1.2.0 [Gateway API 1.2.0] Upgrade Gateway API to 1.2.0-rc1 Sep 26, 2024
Signed-off-by: Huabing Zhao <[email protected]>
@zirain

This comment was marked as outdated.

@arkodg

This comment was marked as outdated.

@zhaohuabing zhaohuabing changed the title [Gateway API 1.2.0] Upgrade Gateway API to 1.2.0-rc1 [Gateway API 1.2.0] Upgrade Gateway API to 1.2.0-rc2 Sep 27, 2024
arkodg
arkodg previously approved these changes Sep 27, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zirain

This comment was marked as outdated.

Signed-off-by: Huabing Zhao <[email protected]>
@@ -274,13 +275,14 @@ func migrateChartCRDs(actionConfig *action.Configuration, gatewayChart *chart.Ch
}

for _, crd := range crds {
if crd.Name == "backendtlspolicies.gateway.networking.k8s.io" {
if crd.Name == "backendtlspolicies.gateway.networking.k8s.io" ||
crd.Name == "grpcroutes.gateway.networking.k8s.io" {
Copy link
Member Author

@zhaohuabing zhaohuabing Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://gateway-api.sigs.k8s.io/guides/?h=upgrade#v11-upgrade-notes

GRPCRoute graduated to GA, and the v1alpha2 was removed.

@zhaohuabing zhaohuabing added the release-note Indicates a required release note label Sep 29, 2024
@zhaohuabing zhaohuabing merged commit db1f437 into envoyproxy:main Oct 1, 2024
28 checks passed
@zhaohuabing zhaohuabing deleted the gateway-api-upgrade branch October 1, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Indicates a required release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants