Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_go calls to match Envoy WORKSPACE #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isaacd9
Copy link

@isaacd9 isaacd9 commented Mar 12, 2019

Currently, when trying to build the //:envoy target as described in the README, the build fails immediately with:

INFO: Invocation ID: 70b43f0a-bebd-4eb0-ac07-3fcc68e499af
ERROR: Failed to load Starlark extension '@io_bazel_rules_go_compat//:compat.bzl'.
It usually happens when the repository is not defined prior to being used.
Maybe repository 'io_bazel_rules_go_compat' was defined later in your WORKSPACE file?
ERROR: cycles detected during target parsing
INFO: Elapsed time: 9.699s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

This PR updates the rules_go directives in the WORKSPACE of this repository to match those of Envoy at HEAD of master and should fix the build.

Copy link

@TonyDou TonyDou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, it fixes the build break in this repo.

Copy link

@TonyDou TonyDou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the build build in the current example filter.

Base automatically changed from master to main January 15, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants