Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Don't perform CLI secret initialisation unless needed #4028

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

tigattack
Copy link
Contributor

Description

Calling GetOrCreateClISecret() can cause issues in some unattended scenarios.

I'm creating a Brew formula for ente CLI with the following test:

  test do
    assert_match "Version #{version}", shell_output("#{bin}/ente version")
  end

When running brew test for the formula, ente would fail with the following error: 2024/11/13 11:49:56 error setting password in keyring: exit status 154

And I would see this pop-up:

image

Calling `GetOrCreateClISecret()` can cause issues in some unattended scenarios.
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024

CLA assistant check
All committers have signed the CLA.

@S33G
Copy link
Contributor

S33G commented Nov 13, 2024

nice

@tigattack tigattack changed the title [cli] Don't perform CLI secret initialisation when not needed [cli] Don't perform CLI secret initialisation unless needed Nov 13, 2024
@ua741 ua741 merged commit ce61965 into ente-io:main Nov 14, 2024
1 check passed
@mathieutu
Copy link

@tigattack Hey, sorry I'm just seeing your message.
I already made the PR to Homebrew. 😬
Linux test does not pass, feel free to update it if you understand why. 🙂

@ua741 Could we release this change? We won't probably be able to see the formula merged until the error is fixed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants