[cli] Don't perform CLI secret initialisation unless needed #4028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calling
GetOrCreateClISecret()
can cause issues in some unattended scenarios.I'm creating a Brew formula for ente CLI with the following test:
When running
brew test
for the formula, ente would fail with the following error:2024/11/13 11:49:56 error setting password in keyring: exit status 154
And I would see this pop-up: