Fix unclosed 'MemoryObjectReceiveStream' upon exception in 'BaseHTTPMiddleware' children

[Kludex]

I open a different PR to remove the close_recv_stream_on_response_sent. I'm not sure that's why the test is failing...

[Kludex]

Remove this as per @graingert comment on https://matrix.to/#/!JfFIjeKHlqEVmAsxYP:gitter.im/$S0X8-1wH1qscoq6FQjVCVDgBL4Qk-5BcTnaQfqBCkGI?via=gitter.im&via=matrix.org&via=matrix.freyachat.eu

[Kludex]

Well... I'm very confused as to why the current test is failing. 😆

[graingert]

hmm, 3.8 is EOL so probably getting an old anyio?

edit 1: I ran the test suite locally and got the failure once, running the suite again 3 more times did not reproduce it

edit 2: I deleted my pyc files, ran and it passed. I deleted my pyc files again and recreated my venv and it passed

[Kludex]

The flakiness worries me. Do you know why? Even if it's an old version of anyio.

[graingert]

I'm going to try running it 1000x

[graingert]

for future reference in case the CI logs expire, in python3.8 CI the failure is:

=================================== FAILURES ===================================
_______________ test_websocket_endpoint_on_receive_text[asyncio] _______________

test_client_factory = functools.partial(<class 'starlette.testclient.TestClient'>, backend='asyncio', backend_options={})

    def test_websocket_endpoint_on_receive_text(
        test_client_factory: TestClientFactory,
    ) -> None:
        class WebSocketApp(WebSocketEndpoint):
            encoding = "text"
    
            async def on_receive(self, websocket: WebSocket, data: str) -> None:
                await websocket.send_text(f"Message text was: {data}")
    
        client = test_client_factory(WebSocketApp)
        with client.websocket_connect("/ws") as websocket:
            websocket.send_text("Hello, world!")
            _text = websocket.receive_text()
            assert _text == "Message text was: Hello, world!"
    
        with pytest.raises(RuntimeError):
            with client.websocket_connect("/ws") as websocket:
>               websocket.send_bytes(b"Hello world")
E               Failed: DID NOT RAISE <class 'RuntimeError'>

tests/test_endpoints.py:134: Failed
================== 1 failed, 878 passed, 4 xfailed in 13.38s ===================

[graingert]

ah I think it's a race condition here:

starlette/starlette/testclient.py

Lines 132 to 136 in 29b9c42

	while not self._send_queue.empty():
	message = self._send_queue.get()
	if isinstance(message, BaseException):
	raise message

the other thread could be busy doing stuff moments before trying to put a message on the queue, so the queue appears empty when there's a message pending being put

You need to use queue.shutdown() 3.13+ or send an explicit EOF object when the queue is done with

[graingert]

I think this is a pre-existing issue, just VERY rare

[Kludex]

The problem this solves is not related to this PR then?

[graingert]

yes probably best to split into two PRs and add a changelog entry for the lost shutdown exception issue

[graingert]

omg it's still possible to fail!?

[Kludex]

Hmmm... Then it's not the queue shutdown thingy?

[graingert]

rather than continue to hijack your PR I've opened a new one #2814

[graingert]

truly bizarre