Skip to content

Commit

Permalink
[HIPIFY][ROCm#1024][doc] Do not need to build any LLVM targets for LL…
Browse files Browse the repository at this point in the history
…VM >= 10.0.0 anymore

[Reason]
+ With excluding tests from LLVM building (ROCm#1024), it turned out that building of any of the LLVM targets (`X86` or `NVPTX`) are not needed for hipify-clang as well:
  - Actually, there were some minor dependencies (probably erroneous) between some tests and targets in some LLVM versions, which were entirely gone with tests' exclusion
+ It was needed to check `-DLLVM_TARGETS_TO_BUILD=""`, because hipify-clang is also can be built under `HIPIFY_INCLUDE_IN_HIP_SDK` against ROCm's LLVM, which build is not targeting `NVPTX`
+ Reduction of LLVM compilation time up to two times

+ Building and testing of hipify-clang were checked against all LLVM versions >= 10.0.0 built with `-DLLVM_TARGETS_TO_BUILD=""`

[ToDo]
+ [Not IMP] Check `-DLLVM_TARGETS_TO_BUILD=""` for LLVM < 10.0.0
  • Loading branch information
emankov committed Sep 19, 2023
1 parent 7187ddd commit d2c9298
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/hipify-clang.md
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ Run `Visual Studio 16 2019`, open the generated `LLVM.sln`, build all, and build
```bash
cmake \
-DCMAKE_INSTALL_PREFIX=../dist \
-DLLVM_TARGETS_TO_BUILD="X86;NVPTX" \
-DLLVM_TARGETS_TO_BUILD="" \
-DLLVM_ENABLE_PROJECTS="clang" \
-DLLVM_INCLUDE_TESTS=OFF \
-DCMAKE_BUILD_TYPE=Release \
Expand All @@ -317,7 +317,7 @@ Run `Visual Studio 16 2019`, open the generated `LLVM.sln`, build all, and build
-A x64 \
-Thost=x64 \
-DCMAKE_INSTALL_PREFIX=../dist \
-DLLVM_TARGETS_TO_BUILD="NVPTX" \
-DLLVM_TARGETS_TO_BUILD="" \
-DLLVM_ENABLE_PROJECTS="clang" \
-DLLVM_INCLUDE_TESTS=OFF \
-DCMAKE_BUILD_TYPE=Release \
Expand Down

0 comments on commit d2c9298

Please sign in to comment.