Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MPI runtime requirement for ParMETIS test #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ocaisa
Copy link

@ocaisa ocaisa commented Oct 25, 2018

The test run of ParMETIS is done without the use of MPIEXEC_EXECUTABLE and this can lead to false negatives with some MPI implementations. This change further trivialises the test code to avoid this issue (and, given the FIXME, is equivalent).

The test run of ParMETIS is done without the use of `MPIEXEC_EXECUTABLE` and this can lead to false negatives with some MPI implementations. This change further trivialises the test code to avoid this issue (and, given the `FIXME`, is equivalent).
@poulson
Copy link
Member

poulson commented Oct 25, 2018

Please ignore the Travis failure: it was just a timeout. I am not sure of the utility of removing the MPI calls (MPI is required for ParMETIS), but adding an explicit ParMETIS call would be a much-needed addition.

@ocaisa
Copy link
Author

ocaisa commented Oct 25, 2018

Yes, MPI is required for ParMETIS but the existing test does not launch using MPIEXEC_EXECUTABLE (i.e., there is no real MPI environment). On our system with the latest Intel MPI the current test incorrectly results in

...and run output:
Abort(1094031) on node 0 (rank 0 in comm 0): Fatal error in PMPI_Init: Other MPI error, error stack:
MPIR_Init_thread(607)......: 
MPID_Init(793).............: 
MPIDI_NM_mpi_init_hook(667): OFI addrinfo() failed (ofi_init.h:667:MPIDI_NM_mpi_init_hook:No data available)

Return value: 143

which is purely because the compiled code was run directly rather than via MPIEXEC_EXECUTABLE. I don't know CMake well enough in order to suggest something but if you want to add the ParMETIS call (which I also don't know very well, I'm just installing Elemental for someone) then you would need to fix this.

@poulson
Copy link
Member

poulson commented Oct 25, 2018

I am no longer maintaining Elemental (I quit my job and am starting up new open source scientific computing projects). I prefer to know less about CMake than I do and have switched to Meson.

@ocaisa
Copy link
Author

ocaisa commented Oct 25, 2018

Ok, no problem ;)
Feel free to close this, we will just patch the release.
Good luck with the new projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants