Text_similarity_reranker retriever rework to be evaluated during rewrite phase #114085
+549
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmpailis
added
>non-issue
:Search Relevance/Ranking
|
@elasticmachine update branch |
…/elasticsearch into text_similarity_reranker_rework
pmpailis
commented
Oct 4, 2024
| @@ -32,7 +38,7 @@ | |||
| /** | |||
| * A {@code RetrieverBuilder} for parsing and constructing a text similarity reranker retriever. | |||
| */ | |||
| public class TextSimilarityRankRetrieverBuilder extends RetrieverBuilder { | |||
| public class TextSimilarityRankRetrieverBuilder extends CompoundRetrieverBuilder<TextSimilarityRankRetrieverBuilder> { | |||
|
|
|||
| public static final NodeFeature TEXT_SIMILARITY_RERANKER_RETRIEVER_SUPPORTED = new NodeFeature( | |||
| "text_similarity_reranker_retriever_supported" | |||
There was a problem hiding this comment.
Should we introduce a new cluster feature as we did with rrf ?
pmpailis
commented
Oct 4, 2024
| @@ -87,11 +87,9 @@ setup: | |||
| - length: { hits.hits: 2 } | |||
|
|
|||
| - match: { hits.hits.0._id: "doc_2" } | |||
| - match: { hits.hits.0._rank: 1 } | |||
There was a problem hiding this comment.
_rank has now been removed as with rrf.
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #112648 has been merged, in this PR we handle the
text_similarity_rerankerretriever next, so that it can be evaluated during the rewrite phase and be transformed to a flattenedRankDocsRetrieverBuilder. This will enable us to support composition and many search features, including highlighting, aggregations, and collapsing.