Fix HuggingFaceMixedIT test sometimes failing when run on version before 8.16 #114061
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
external-contributor
dan-rubinstein
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, chunking settings were added to HuggingFaceService. This means that the integration tests will now generate models with chunking settings. When running the mixed cluster integration tests it is possible that the inference index that stores the models is created based off of the mapping known to the older node in the cluster (this does not always happen but it can). If this node is pre-8.16, then the index mapping will not have chunking settings which will cause the mixed integration test to fail to store a model with chunking settings. We ran into this issue with OpenAIServiceMixedIT as well and did a similar fix to catch this exception and successfully complete the test as this is the expected behavior.
The HuggingFaceService changes have not been backported to 8.x yet. Once this is merged to main, we can include it in the backport - #113886