Use unwind-protect to ensure action chain is inactive afterwards #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could not find out how to write a unit test for this without adjusting el-mock. I've created a pull-request there (rejeep/el-mock.el#26), to support providing a lambda for a stub. After there is any progress on that pull-request I can decide how to continue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The step "When I execute the action chain" does not ensure the action chain is inactive afterwards when a non-local exit (error or throw) happens during execution of the action chain.
This pull-request should fix that.
I'm not yet familiar with writing ert-tests, if you think this should be explicitely tested, please help me construct the testcase.