[StepSecurity] Apply security best practices (#230) #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netomi
reviewed
Apr 27, 2023
| @@ -112,7 +112,7 @@ jobs: | |||
|
|
|||
| - name: Check license vetting status (and ask for review if requested) | |||
| id: check-license-vetting | |||
| uses: eclipse/dash-licenses/.github/actions/maven-license-check-action@master | |||
| uses: eclipse/dash-licenses/.github/actions/maven-license-check-action@f12cb1ced8fb5d92acdd9a4ad5930075a94cc675 # master | |||
There was a problem hiding this comment.
I would not use a fixed hash for this action.
It is an action hosted within the repo itself. When you change the workflow, you would have to change this workflow as well, referencing the new version of it (cant be done in the same commit btw).
Also when someone is able to manipulate the tags of this repo, this should be our least concern.
There was a problem hiding this comment.
Thanks, for the feedback, it sounds reasonable. I am updating and commenting as an exception
resolve: eclipse-dash#230 Signed-off-by: StepSecurity Bot <[email protected]>
ghost
force-pushed
the
stepsecurity_remediation_1682609380
branch
from
859e090
to
5c9f008
Compare
|
@netomi are you content with the updates? Shall I merge? |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is created by Secure Repo at the request of @fperezel. Please merge the Pull Request to incorporate the requested changes. Please tag @fperezel on your message if you have any questions related to the PR. You can also engage with the StepSecurity team by tagging @step-security-bot.
Security Fixes
Pinned Dependencies
GitHub Action tags and Docker tags are mutatble. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.
Keeping your actions up to date with Dependabot
With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).
Feedback
For bug reports, feature requests, and general feedback; please create an issue in step-security/secure-repo. To create such PRs, please visit https://app.stepsecurity.io/securerepo.
Signed-off-by: StepSecurity Bot [email protected]